-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Record sessionStarted telemetry event in Setting Store #11334
Merged
fedme
merged 2 commits into
master
from
ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend
Oct 22, 2024
Merged
fix(editor): Record sessionStarted telemetry event in Setting Store #11334
fedme
merged 2 commits into
master
from
ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedme
changed the title
fix: Record sessionStarted telemetry event in Setting Store
fix(editor): Record sessionStarted telemetry event in Setting Store
Oct 21, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 21, 2024
fedme
commented
Oct 21, 2024
netroy
approved these changes
Oct 21, 2024
netroy
added
the
release/backport
Changes that need to be backported to older releases.
label
Oct 21, 2024
n8n Run #7481
Run Properties:
|
Project |
n8n
|
Branch Review |
ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend
|
Run status |
Passed #7481
|
Run duration | 04m 25s |
Commit |
36a8a99190: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 fedme 🗃️ e2e/*
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
458
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
mutdmour
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for adding tests as well
✅ All Cypress E2E specs passed |
fedme
deleted the
ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend
branch
October 22, 2024 15:48
r00gm
pushed a commit
that referenced
this pull request
Oct 24, 2024
…11334) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Closed
r00gm
pushed a commit
that referenced
this pull request
Oct 24, 2024
…11334) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Closed
cstuncsik
pushed a commit
that referenced
this pull request
Oct 24, 2024
…11334) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
release/backport
Changes that need to be backported to older releases.
Released
ui
Enhancement in /editor-ui or /design-system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restores the "Session started" telemetry event that was accidentally removed in d62cfca#diff-056a9fd49f06d2d7a23d984175528aa82fddc8cb23e91a2cc4b8d35c3c674d6cL249
Related Linear tickets, Github issues, and Community forum posts
ADO-2744
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)