Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Record sessionStarted telemetry event in Setting Store #11334

Conversation

fedme
Copy link
Contributor

@fedme fedme commented Oct 21, 2024

Summary

Restores the "Session started" telemetry event that was accidentally removed in d62cfca#diff-056a9fd49f06d2d7a23d984175528aa82fddc8cb23e91a2cc4b8d35c3c674d6cL249

Related Linear tickets, Github issues, and Community forum posts

ADO-2744

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@fedme fedme requested review from netroy and mutdmour October 21, 2024 16:59
@fedme fedme changed the title fix: Record sessionStarted telemetry event in Setting Store fix(editor): Record sessionStarted telemetry event in Setting Store Oct 21, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 21, 2024
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Oct 21, 2024
Copy link

cypress bot commented Oct 21, 2024

n8n    Run #7481

Run Properties:  status check passed Passed #7481  •  git commit 36a8a99190: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 fedme 🗃️ e2e/*
Project n8n
Branch Review ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend
Run status status check passed Passed #7481
Run duration 04m 25s
Commit git commit 36a8a99190: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 fedme 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding tests as well

Copy link
Contributor

✅ All Cypress E2E specs passed

@fedme fedme merged commit 1b734dd into master Oct 22, 2024
77 checks passed
@fedme fedme deleted the ado-2744-bug-session-started-is-not-being-fired-anymore-via-backend branch October 22, 2024 15:48
r00gm pushed a commit that referenced this pull request Oct 24, 2024
…11334)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
r00gm pushed a commit that referenced this pull request Oct 24, 2024
…11334)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
cstuncsik pushed a commit that referenced this pull request Oct 24, 2024
…11334)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
This was referenced Oct 24, 2024
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants