feat(editor): Upgrade @sentry/vue to address GHSA-593m-55hh-j8gv (n…

…o-changelog) (#11169)
n8n-io · Oct 8, 2024 · 94cfb37 · 94cfb37
1 parent af4f4a0
commit 94cfb37
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 64 deletions.
diff --git a/packages/editor-ui/package.json b/packages/editor-ui/package.json
@@ -38,7 +38,7 @@
     "@n8n/codemirror-lang": "workspace:*",
     "@n8n/codemirror-lang-sql": "^1.0.2",
     "@n8n/permissions": "workspace:*",
-    "@sentry/vue": "^8.31.0",
+    "@sentry/vue": "catalog:frontend",
     "@vue-flow/background": "^1.3.0",
     "@vue-flow/controls": "^1.1.2",
     "@vue-flow/core": "^1.41.2",

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
@@ -116,10 +116,6 @@ declare global {
 		};
 		// eslint-disable-next-line @typescript-eslint/naming-convention
 		Cypress: unknown;
-
-		Sentry?: {
-			captureException: (error: Error, metadata?: unknown) => void;
-		};
 	}
 }
 

diff --git a/packages/editor-ui/src/components/ParameterInputList.vue b/packages/editor-ui/src/components/ParameterInputList.vue
@@ -29,6 +29,7 @@ import {
 } from '@/utils/nodeTypesUtils';
 import { get, set } from 'lodash-es';
 import { useRouter } from 'vue-router';
+import { captureException } from '@sentry/vue';
 
 const LazyFixedCollectionParameter = defineAsyncComponent(
 	async () => await import('./FixedCollectionParameter.vue'),
@@ -73,7 +74,7 @@ onErrorCaptured((e, component) => {
 	}
 	asyncLoadingError.value = true;
 	console.error(e);
-	window?.Sentry?.captureException(e, {
+	captureException(e, {
 		tags: {
 			asyncLoadingError: true,
 		},

diff --git a/packages/editor-ui/src/plugins/codemirror/resolvableHighlighter.ts b/packages/editor-ui/src/plugins/codemirror/resolvableHighlighter.ts
@@ -3,6 +3,7 @@ import { EditorView, Decoration } from '@codemirror/view';
 import { StateField, StateEffect } from '@codemirror/state';
 import { tags } from '@lezer/highlight';
 import { syntaxHighlighting, HighlightStyle } from '@codemirror/language';
+import { captureException } from '@sentry/vue';
 
 import type {
 	ColoringStateEffect,
@@ -87,7 +88,7 @@ const coloringStateField = StateField.define<DecorationSet>({
 				}
 			}
 		} catch (error) {
-			window?.Sentry?.captureException(error);
+			captureException(error);
 		}
 
 		return colorings;

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -27,6 +27,7 @@ catalog:
 catalogs:
   frontend:
     '@vitest/coverage-v8': ^2.0.5
+    '@sentry/vue': ^8.33.1
     vite: ^5.4.6
     vitest: ^2.1.1
     vitest-mock-extended: ^2.0.2