👌 Removing unnecessary map from stale field check method

n8n-io · Dec 20, 2024 · 675f4fa · 675f4fa
1 parent 25412ca
commit 675f4fa
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/packages/editor-ui/src/utils/nodeTypesUtils.ts b/packages/editor-ui/src/utils/nodeTypesUtils.ts
@@ -448,13 +448,12 @@ export const isResourceMapperFieldListStale = (
 		return true;
 	}
 
-	// Create maps for O(1) lookup
-	const oldFieldsMap = new Map(oldFields.map((field) => [field.id, field]));
+	// Create map for O(1) lookup
 	const newFieldsMap = new Map(newFields.map((field) => [field.id, field]));
 
 	// Check if any fields were removed or modified
-	for (const [id, oldField] of oldFieldsMap) {
-		const newField = newFieldsMap.get(id);
+	for (const oldField of oldFields) {
+		const newField = newFieldsMap.get(oldField.id);
 
 		// Field was removed
 		if (!newField) {