Pin WASM bindgen (bitwarden#1129)

Every time wasm-bindgen is updated we run into conflicts with the wasm-bindgen-cli version. Pin it to avoid this problem in the future.
mzieniukbw · Oct 11, 2024 · 97116b1 · 97116b1
1 parent 7e90f52
commit 97116b1
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/.github/workflows/build-wasm-internal.yml b/.github/workflows/build-wasm-internal.yml
@@ -46,7 +46,7 @@ jobs:
           key: wasm-cargo-cache
 
       - name: Install wasm-bindgen-cli
-        run: cargo install wasm-bindgen-cli
+        run: cargo install wasm-bindgen-cli --version 0.2.95
 
       - name: Build
         run: ./build.sh -r

diff --git a/.github/workflows/build-wasm.yml b/.github/workflows/build-wasm.yml
@@ -46,7 +46,7 @@ jobs:
           key: wasm-cargo-cache
 
       - name: Install wasm-bindgen-cli
-        run: cargo install wasm-bindgen-cli
+        run: cargo install wasm-bindgen-cli --version 0.2.95
 
       - name: Build
         run: ./build.sh -r

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/bitwarden-wasm-internal/Cargo.toml b/crates/bitwarden-wasm-internal/Cargo.toml
@@ -21,7 +21,8 @@ console_log = { version = "1.0.0", features = ["color"] }
 js-sys = "0.3.68"
 log = "0.4.20"
 serde_json = ">=1.0.96, <2.0"
-wasm-bindgen = { version = "0.2.91", features = ["serde-serialize"] }
+# When upgrading wasm-bindgen, make sure to update the version in the workflows!
+wasm-bindgen = { version = "=0.2.95", features = ["serde-serialize"] }
 wasm-bindgen-futures = "0.4.41"
 
 [lints]

diff --git a/crates/bitwarden-wasm/Cargo.toml b/crates/bitwarden-wasm/Cargo.toml
@@ -25,7 +25,8 @@ console_log = { version = "1.0.0", features = ["color"] }
 js-sys = "0.3.68"
 log = "0.4.20"
 serde = { version = "1.0.196", features = ["derive"] }
-wasm-bindgen = { version = "0.2.91", features = ["serde-serialize"] }
+# When upgrading wasm-bindgen, make sure to update the version in the workflows!
+wasm-bindgen = { version = "=0.2.95", features = ["serde-serialize"] }
 wasm-bindgen-futures = "0.4.41"
 
 [dev-dependencies]