Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sizing issue w/ bg video which made the #244

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Apr 20, 2024

blur image not show before either img or video got dimensions via their url sources.

I also got reminded that we can probably get the aspectRatio from the tiny image on the server and store that.
that way the user doesn't need to manually set it.

blur image not show before either img or video got
dimensions via their url sources
@luwes luwes self-assigned this Apr 20, 2024
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 1:51am

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (7e51926) to head (2c678e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files          30       30           
  Lines        2405     2405           
  Branches      335      335           
=======================================
  Hits         2179     2179           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes merged commit bd0471c into muxinc:main Apr 20, 2024
6 checks passed
@luwes luwes deleted the bgvideo-sizing branch November 21, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants