FEAT(server): Allow running while DB is in read-only mode #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter with the server-ID is not user-provided but rather an implicit parameter identifying the Server object the function is called on (handled by the Ice backend). Therefore, it can be assumed that this ID belongs to a valid server. This makes an explicit check superfluous and since this check may even require a database lookup, it has been removed. Instead, the passed server ID is assumed to be correct and therefore returned as-is.
Note that the server's feature set is reduced to the absolute minimum and most requests to the server will simply be dropped. Only users that have already been on the server when it entered this mode will be able to stay on the server and keep talking to each other. No new connections will be accepted and nobody can move channels or perform any other noteworthy actions (except writing text messages, which will still work). This mode is explicitly meant to be used only for short periods of time that might be needed to perform a database backup etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the server's feature set is reduced to the absolute minimum
and most requests to the server will simply be dropped. Only users
that have already been on the server when it entered this mode will be
able to stay on the server and keep talking to each other. No new
connections will be accepted and nobody can move channels or perform any
other noteworthy actions (except writing text messages, which will still
work).
This mode is explicitly meant to be used only for short periods of time
that might be needed to perform a database backup etc.
Checks