Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Update Debian Build-Dependencies #6646

Merged
merged 3 commits into from
Dec 10, 2024
Merged

DOCS: Update Debian Build-Dependencies #6646

merged 3 commits into from
Dec 10, 2024

Conversation

diederikdehaas
Copy link
Contributor

This MR consists of the following 3 commits:

  • DOCS(build_linux): Sort Debian Build Dependencies
  • DOCS(build_linux): Actually update Debian B-D: pkg-config -> pkgconf
  • DOCS(build_linux): Add missing B-Ds to Debian instructions

Feel free to (ask me to) squash those into 1 (or 2) commit(s).

Checks

@diederikdehaas diederikdehaas mentioned this pull request Dec 2, 2024
Closed
@diederikdehaas diederikdehaas changed the title Update Debian Build-Dependencies Draft: Update Debian Build-Dependencies Dec 2, 2024
@diederikdehaas
Copy link
Contributor Author

I marked the PR as Draft as I'm going to do some additional research

@Krzmbrzl Krzmbrzl marked this pull request as draft December 3, 2024 15:17
@Krzmbrzl Krzmbrzl changed the title Draft: Update Debian Build-Dependencies DOCS: Update Debian Build-Dependencies Dec 3, 2024
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Dec 3, 2024 •
edited
Loading

Feel free to (ask me to) squash those into 1 (or 2) commit(s).

Nah, I actually like the way it is right now :)

P.S.: Just let me know when you are finished with researching and consider this PR finalized

@diederikdehaas
Copy link
Contributor Author

Most likely case will be that I'll drop libpipewire-0.3-dev and add libmsgsl-dev, but I'll let you know when I finished that :-)

@diederikdehaas
DOCS(build_linux): Sort Debian Build Dependencies
2a38114 
This makes it (much) easier to check whether one has all the Build
Dependencies installed or not.
@diederikdehaas
DOCS(build_linux): Actually update Debian B-D: pkg-config -> pkgconf
55d5be2 
Since Debian Bookworm the pkg-config package is a transitional package
to pkgconf, so update the build dependency install instructions to point
to its target.

In PR 6643 I accidentally updated the instructions for Ubuntu instead of
for Debian, so now actually update the instructions for Debian as well.
FTR: In Ubuntu Noble (2024.04) it's also a transitional package.

Link: mumble-voip#6643
@diederikdehaas
DOCS(build_linux): Add missing B-Ds to Debian instructions
9c7877f 
Mumble can be compiled with several system libraries, so add their
development library to the list of Build-Depends.
In order to actually compile with them, you need to specify the
configuration options as described in cmake_options.md.

Those are for the newly added B-Ds:
1) -Dbundled-gsl=OFF
2) -Dbundled-speex=OFF
3) -Dbundled-json=OFF

Closes: mumble-voip#6644
@diederikdehaas
Copy link
Contributor Author

AFAIC it's now finalized :-)

@diederikdehaas
Copy link
Contributor Author

I guess I can't remove the 'Draft' status? On GitLab you can do that by editing the title, but that didn't have the expected result here when I tried it and I haven't found a button (or sth like that) to change the status myself.

@Hartmnt
Copy link
Member

Hartmnt commented Dec 7, 2024 •
edited
Loading

I guess I can't remove the 'Draft' status? On GitLab you can do that by editing the title, but that didn't have the expected result here when I tried it and I haven't found a button (or sth like that) to change the status myself.

In the upper right in the same place where you can request a review. Absolutely intuitive I know 🙃

Or at the very bottom "Ready for review"

@diederikdehaas
Copy link
Contributor Author

diederikdehaas commented Dec 7, 2024 •
edited
Loading

In the upper right in the same place where you can request a review. Absolutely intuitive I know

I guess that should be in the area which list the Reviewers? (where also Assignees are listed) ... yeah I don't see a button or menu item there to do that (or I'm blind), so I guess that is actually a permission thing.

Or at the very bottom "Ready for review"

But I do see that, thanks!

EDIT: After I marked it as ready, I now do see "Still in progress? <link to Convert to draft>"

@diederikdehaas diederikdehaas marked this pull request as ready for review December 7, 2024 15:11
@Hartmnt
Copy link
Member

Hartmnt commented Dec 8, 2024

I guess this is fine. Any objections @Krzmbrzl @davidebeatrici ?

@Hartmnt Hartmnt linked an issue Dec 9, 2024 that may be closed by this pull request
(Debian) Build Dependencies: Missing libspeexdsp-dev and libpipewire-0.3-dev? #6644
Closed
@Hartmnt Hartmnt merged commit 627f838 into mumble-voip:master Dec 10, 2024
17 checks passed
@diederikdehaas diederikdehaas deleted the update-debian-BDs branch December 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidebeatrici davidebeatrici davidebeatrici approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Debian) Build Dependencies: Missing libspeexdsp-dev and libpipewire-0.3-dev?
4 participants
@diederikdehaas @Krzmbrzl @Hartmnt @davidebeatrici