FEAT(client): Control + mouse wheel scroll to adjust local volume in TalkingUI #6629
Conversation
…TalkingUI This new feature allows to change the local volume adjustment for the selected user by scrolling the mouse wheel up (increase) or down (decrease) while Control is pressed.
davidebeatrici
force-pushed
the
talkingui-ctrl-scroll-local-vol-adj
branch
from
b7f9676 to
271f727
Compare
|
I will look at this in detail after the next 1.5.x release |
| @@ -375,6 +375,7 @@ struct Settings { | |||
| bool bTalkingUI_AbbreviateChannelNames = true; | |||
| bool bTalkingUI_AbbreviateCurrentChannel = false; | |||
| bool bTalkingUI_ShowLocalListeners = false; | |||
| bool talkingUI_CtrlScrollLocalVolAdj = false; | |||
There was a problem hiding this comment.
Since the number of people never noticing this feature exists is probably higher than those who would be annoyed by this, I guess it would make sense to enable this by default.
| if (volAdjustment >= 30) { | ||
| // 30 dB is the upper limit defined for the volume slider (VolumeSliderWidgetAction.cpp). |
There was a problem hiding this comment.
This would be a great reason to implement some kind of member in VolumeSliderWidgetAction that returns the min/max in case we ever want to change it again.
| </widget> | ||
| </item> | ||
| <item row="5" column="0"> | ||
| <widget class="QCheckBox" name="qcbCtrlScrollLocalVolAdj"> |
There was a problem hiding this comment.
Please update the tab order such that it includes this new element at the correct position. Should be possible to do visually using Qt-Designer.
| volAdjustment -= 1; | ||
| } | ||
|
|
||
| user->setLocalVolumeAdjustment(VolumeAdjustment::toFactor(volAdjustment)); |
There was a problem hiding this comment.
This does set the new local volume temporarily, but it is not retained. You can test this by adjusting the volume using your method and then changing client state of the user you adjusted (e.g. deafen and immediately undeafen)
To retain the changes we need to add:
Global::get().db->setUserLocalVolume(user->qsHash, user->getLocalVolumeAdjustments());
| return; | ||
| } | ||
|
|
||
| ClientUser *user = Global::get().mw->pmModel->getSelectedUser(); |
There was a problem hiding this comment.
"Weird" things happen, if you enable to always show your local user (or channel listeners) and use this scroll event. Mainly, it changes the local volume of yourself which has currently no effect IIRC, but can not be changed back using the "self" context menu.
Unless we plan to use self-local-volume-adjustment for something, I think you should add a check that we are not able to change the local volume of ourselves.
| @@ -569,6 +571,41 @@ void TalkingUI::mousePressEvent(QMouseEvent *event) { | |||
| updateUI(); | |||
| } | |||
|
|
|||
| void TalkingUI::wheelEvent(QWheelEvent *event) { | |||
There was a problem hiding this comment.
This brings me to my next consideration: Why are we only allowing this in the Talking UI? It feels like the main user list could also profit from this. Maybe I am missing something you already considered?
This new feature allows to change the local volume adjustment for the selected user by scrolling the mouse wheel up (increase) or down (decrease) while Control is pressed.