Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-2691] Performance improvements and caching fixes #1521

Merged

Conversation

mad2sm0key
Copy link
Contributor

Reasoning

  • using falsy checks instead of explicit undefined checks inside the cache getAllKeys method triggers unnecessary individual redis GET requests for cached booleans / the number 0
  • LP tokens metadata is only being cached on request resulting in slow queries for the first user that needs the data
  • dataloaders have a default in-memory cache enabled

Proposed Changes

  • disable caching for pair (abi + compute) and tokens dataloaders
  • add dataloader for pair 24h volume
  • cache warm LP tokens metadata
  • replace falsy check with explicit undefined check in getAllKeys util function

How to test

  • N/A

@bogdan-rosianu bogdan-rosianu self-requested a review November 5, 2024 13:43
@mad2sm0key mad2sm0key merged commit 3384783 into development Nov 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants