Fix F11 map crash caused by #3823 #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blue into radar-jpg-update
Co-authored-by: Uladzislau Nikalayevich <[email protected]>
Co-authored-by: Uladzislau Nikalayevich <[email protected]>
Co-authored-by: Uladzislau Nikalayevich <[email protected]>
…blue into radar-jpg-update
This reverts commit 7e9f0d6.
…d before attempting to free
|
Still blocked by the following from dev discord:
|
TheNormalnij
approved these changes
Dec 22, 2024
botder
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment: #3823 (comment)
There was a try cath block that could skip m_playerMarkerTexture initializing. This resulted in access violation when trying to free m_playerMarkerTexture in the CPlayerMap destructor. m_playerMarkerTexture = nullptr was missing in the constructor.
This commit fixes the problem: bb6c33e
cc @Dutchman101 @TheNormalnij