Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re:#926, Fix #925 Memory Leak while WebSocketServerHandshakeException… #987

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

h3mant-1
Copy link
Contributor

… or Channel failed

@h3mant-1
Copy link
Contributor Author

@mrniko Please see if we merge this patch.

@mrniko mrniko merged commit bebdad6 into mrniko:master Jul 24, 2024
2 checks passed
@mrniko
Copy link
Owner

mrniko commented Jul 24, 2024

Thanks for contribution!

@mrniko mrniko added this to the 2.0.10 milestone Jul 24, 2024
@mrniko mrniko added the bug label Jul 24, 2024
@berinhardt
Copy link
Contributor

berinhardt commented Jul 26, 2024

I'm not sure, but I feel that always removing the client from uuid2client is wrong.

if the handshake fails on reconnection (with a sid) due to a recoverable cause (I'm thinking that maybe the writeFlush failed becaouse of reasons) this fix removes any chance for recovery wouldn't it be valuable to check, for instance, if it had time to add namespaces before closing it?

made a tentative pr with the fix #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants