[DRAFT] Provide Support for Socket IO Protocol V5 #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Missing the `,` separator during an encoding of a namespace packet - Invalid connect packet being sent after connect listeners executed
Any clients who didn't join the default namespace wouldn't be able to have their packets processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm planning to use Netty Socket IO server in production but was unable to use it with the official javascript client due to not supporting protocol version 5 of Socket IO. I didn't knew it didn't support it until I tested the namespace connect event not being fired on the client side. I was quite shocked this library exists since 2013 and the Socket IO don't have it referenced in the language SDKs list.
I'm writing this PR as a draft to get a permission from the author of the repository @mrniko to continue writing the patch for this PR.
The checklist for this PR to keep things clear and easy to track:
8cbf883
remove the implicit connection to the default namespace(Ref: socketio/socket.io@09b6f23)rename
ERRORtoCONNECT_ERROR(Ref: socketio/socket.io@d16c035)the
CONNECTpacket now can contain a payload (Ref: socketio/socket.io@2875d2c)the payload
CONNECT_ERRORpacket is now an object instead of a plain string (Ref: socketio/socket.io@54bf4a4)(Optional) Patching the server to bypass the test-suite test provided by the official Socket IO protocol. Ref
Source
Thank you for your time reading and checking this PR out and have a great day.
God knows best.