Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows library user to choose what executor to use for the server.
In my case, my application makes sure that there are only 2 pools default FJP and one IO thread pool (which has lots of custom telemetry and other custom logic). Most importantly it ensures that there is only one non daemon thread (main thread) everything else is daemon hence when main thread is finished all the resource deallocation tasks which were previously scheduled to Runtime.shutDownHook()... will execute and application will shut down gracefully.
However if i use this library i will end up having another main method, which prevents application from shutting down. For libraries like this i think its important to give option to choose what executors are being used etc...
This change adds option to provide custom executor to Configuration, which will be used to create netty event loop groups...