Support filesystem backup as well as blob store backup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pme-openai
approved these changes
Dec 20, 2024
| @@ -253,6 +272,11 @@ func (backup *FoundationDBBackup) BackupURL() string { | |||
| return backup.Spec.BlobStoreConfiguration.getURL(backup.BackupName(), backup.Bucket()) | |||
| } | |||
|
|
|||
| // mpatou: should we use file:// ? | |||
| if backup.Spec.FSConfiguration != nil { | |||
| return fmt.Sprintf("%s/%s", backup.Spec.FSConfiguration.URL, backup.BackupName()) | |||
There was a problem hiding this comment.
if this is a filesystem path, you should use
Suggested change
| return fmt.Sprintf("%s/%s", backup.Spec.FSConfiguration.URL, backup.BackupName()) | |
| return path.Join(backup.Spec.FSConfiguration.URL, backup.BackupName()) |
There was a problem hiding this comment.
The documentation of fdb indicates that you can use file:// I don't think it would work ?
| } | ||
|
|
||
| // BackupURL gets the destination url of the backup. | ||
| func (restore *FoundationDBRestore) BackupURL() string { | ||
| if restore.Spec.BlobStoreConfiguration != nil { | ||
| return restore.Spec.BlobStoreConfiguration.getURL(restore.BackupName(), restore.Spec.BlobStoreConfiguration.BucketName()) | ||
| } | ||
| if restore.Spec.FSConfiguration != nil { | ||
| return fmt.Sprintf("%s/%s", restore.Spec.FSConfiguration.URL, restore.BackupName()) |
There was a problem hiding this comment.
if this is a filesystem path, you should use
Suggested change
| return fmt.Sprintf("%s/%s", restore.Spec.FSConfiguration.URL, restore.BackupName()) | |
| return path.Join(restore.Spec.FSConfiguration.URL, restore.BackupName()) |
| } | ||
| // mpatou: should we use file:// ? | ||
| if backup.Spec.FSConfiguration != nil { | ||
| return fmt.Sprintf("%s/%s", backup.Spec.FSConfiguration.URL, backup.BackupName()) |
There was a problem hiding this comment.
if this is a filesystem path, you should use
Suggested change
| return fmt.Sprintf("%s/%s", backup.Spec.FSConfiguration.URL, backup.BackupName()) | |
| return path.Join(backup.Spec.FSConfiguration.URL, backup.BackupName()) |
| } | ||
|
|
||
| if restore.Spec.FSConfiguration != nil { | ||
| return fmt.Sprintf("%s/%s", restore.Spec.FSConfiguration.URL, restore.BackupName()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.