Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through --remap-path-prefix argument. #2270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ColinFinck
Copy link

I don't see what's special about the --remap-path-prefix argument that it was marked as TooHard and not just passed through.
I'm changing it to PassThrough here. This change has worked in a local test.

Please put my PR under scrutiny. This argument has been unsupported by sccache for a long time and it feels too simple to just change it to PassThrough.

@sylvestre sylvestre requested a review from glandium October 8, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.71%. Comparing base (0cc0c62) to head (9aebab5).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   30.91%   40.71%   +9.80%     
==========================================
  Files          53       54       +1     
  Lines       20112    20747     +635     
  Branches     9755     9642     -113     
==========================================
+ Hits         6217     8448    +2231     
- Misses       7922     8152     +230     
+ Partials     5973     4147    -1826     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColinFinck
Copy link
Author

Bump

Is there anybody else who could review my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants