Bug 1449105 [wpt PR 10191] - [css-typed-om] Stub list-valued tests., …

…a=testonly Automatic update from web-platform-tests[css-typed-om] Stub list-valued tests. Currently we're just adding a TODO when we want to test a list-valued property. It's probably easier if we stub that test function and then implement it later. Bug: 774887 Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1 Reviewed-on: https://chromium-review.googlesource.com/981956 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Darren Shen <[email protected]> Cr-Commit-Position: refs/heads/master@{#546067} wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb wpt-pr: 10191 wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb wpt-pr: 10191
mozilla · Apr 15, 2018 · 7c3967f · 7c3967f
1 parent 9759a2f
commit 7c3967f
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/testing/web-platform/meta/MANIFEST.json b/testing/web-platform/meta/MANIFEST.json
@@ -523540,7 +523540,7 @@
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/animation-direction.html": [
-   "05e0be2c67fd695d693f2a639acf88ff78d8fd04",
+   "6c988281b4773fa25ef0d811ff6e0cd37a1e0fae",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/backface-visibility.html": [
@@ -523552,7 +523552,7 @@
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/background-image.html": [
-   "1255fea8e74561e14720ccf422fd841e1d3e32fa",
+   "08055b88eca1f841f3b8a9867d8ffeb93d214d1f",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/background.html": [
@@ -523776,7 +523776,7 @@
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/mask-image.html": [
-   "2a20c6818e9d71adbf3902fde74cb26136917e72",
+   "8400ca1a6caf399c5914df06028d6616fb9f9571",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/mix-blend-mode.html": [
@@ -523856,7 +523856,7 @@
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js": [
-   "7e6c530cf36cce5d7b8d02abbbefbdd4370d1be1",
+   "ca6f58ecbab01ee294f4388b456b3b1bdd7a4629",
    "support"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/right.html": [
@@ -523936,7 +523936,7 @@
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/transition-duration.html": [
-   "b735f3ff6dba561cf2e35a8a85a8e2b93c0edc61",
+   "fe613a427b8c057fb859eb70a58d506c6a0b3cde",
    "testharness"
   ],
   "css/css-typed-om/the-stylepropertymap/properties/unicode-bidi.html": [

diff --git a/...-platform/tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html b/...-platform/tests/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: animation-direction is list-valued. Run list-valued tests here too.
-runPropertyTests('animation-direction', [
+runListValuedPropertyTests('animation-direction', [
   { syntax: 'normal' },
   { syntax: 'reverse' },
   { syntax: 'alternate-reverse' },

diff --git a/...web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html b/...web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/background-image.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: background-image is list-valued. Run list-valued tests here too.
-runPropertyTests('background-image', [
+runListValuedPropertyTests('background-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);

diff --git a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: mask-image is list-valued. Run list-valued tests here too.
-runPropertyTests('mask-image', [
+runListValuedPropertyTests('mask-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);

diff --git a/...eb-platform/tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js b/...eb-platform/tests/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
@@ -378,6 +378,12 @@ function runPropertyTests(propertyName, testCases) {
   }
 }
 
+// Same as runPropertyTests but for list-valued properties.
+function runListValuedPropertyTests(propertyName, testCases) {
+  // TODO(https://crbug.com/545318): Run list-valued tests as well.
+  runPropertyTests(propertyName, testCases);
+}
+
 // Check that |propertyName| doesn't "support" examples in |testExamples|.
 // |testExamples| is a list of CSS string values. An "unsupported" value
 // doesn't have a corresponding Typed OM representation. It normalizes as

diff --git a/...-platform/tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html b/...-platform/tests/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
@@ -12,8 +12,7 @@
 <script>
 'use strict';
 
-// FIXME: transition-duration is list-valued. Run list-valued tests here too.
-runPropertyTests('transition-duration', [
+runListValuedPropertyTests('transition-duration', [
   { syntax: '<time>' },
 ]);