Add USE_STATIC_MSVC_RUNTIME cmake option instead of always using statically-linked runtime library
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSauce04
force-pushed
the
cmake-static-msvc-option
branch
from
afd4448 to
d6a407d
Compare
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects for an issue introduced in 877364f which caused anything dynamically linking against cubeb to fail to compile via MSVC due to a mismatched
RuntimeLibraryvalue. There was no clean way to fix this issue in the dependent project due to there being no cmake configuration option to prevent this value from being set.The pull request fixes this by adding a new
USE_STATIC_MSVC_RUNTIMEoption which, when enabled, setsCMAKE_MSVC_RUNTIME_LIBRARYtoMultiThreaded$<$<CONFIG:Debug>:Debug>.If the option is not set,
CMAKE_MSVC_RUNTIME_LIBRARYwill be left at its default value, which as per the cmake documentation isMultiThreaded$<$<CONFIG:Debug>:Debug>DLL.