AAudio: offset position after reinitialization #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reinitializating, `cubeb_stream::previous_clock` isn't reset properly but stream gets reset and restarts `AAudioTimingInfo::output_frame_index` from zero. Therefore, `aaudio_stream_get_position()` always reports previous clock rather than actual position until it is surpassed later. To estimate the position correctly, Save the number of frames sent to stream before it's reset, and use the value as the basis for future position estimation.
padenot
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reinitializating (due to output device change),
cubeb_stream::previous_clockisn't reset properly but stream gets reset and restartsAAudioTimingInfo::output_frame_indexfrom zero. Therefore,aaudio_stream_get_position()always reports previous clock rather than actual position until it is surpassed later. (See Gecko bug.)This patch:
position_interpolatortoposition_estimatefor the additional responsibility.position_estimateas the basis for future position estimation.