MNTOR-3814 - use context to fetch experiment data from Cirrus #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL 🚀 : https://blurts-server-pr-5440-mgjlpikfea-uk.a.run.app |
flozia
reviewed
Dec 20, 2024
Comment on lines
+59
to
+76
| nimbus_user_id: | ||
| description: Nimbus user ID | ||
| type: string | ||
| nimbus_app_id: | ||
| description: Nimbus application ID | ||
| type: string | ||
| nimbus_experiment: | ||
| description: Nimbus experiment name | ||
| type: string | ||
| nimbus_branch: | ||
| description: Nimbus branch | ||
| type: string | ||
| nimbus_experiment_type: | ||
| description: Nimbus experiment type | ||
| type: string | ||
| nimbus_is_preview: | ||
| description: Nimbus preview mode enabled | ||
| type: string |
There was a problem hiding this comment.
Would we need to check in with a data steward to see if these metrics are still covered by our initial data review?
There was a problem hiding this comment.
Yes, so we may not be able to land this until that's done.
rhelmer
changed the title
flozia
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3814
Description
This PR introduces an
ExperimentsContextwith a provider and auseExperiments()hook that can be called by any client component that needs it. I implemented it just for Glean so far (per the linked Jira ticket) but if this approach is OK I can file a followup to move from prop-drilling to this more generally for features that need access to experiment data (which features are activated, what the active branch is, etc)How to test
I've been using the Glean debug dashboard to inspect pings. Note that local pings have
-1for mostEnrollmentsvalues, you need to use Cirrus (or something that mocks it). I'll see if I can mock this to add some automated tests.An easy way to inspect Glean pings is to run this in the browser devtools console:
Which should log:
Checklist (Definition of Done)