Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3857: hardcode batch size #5429

Merged
merged 2 commits into from
Dec 18, 2024
Merged

MNTOR-3857: hardcode batch size #5429

merged 2 commits into from
Dec 18, 2024
+4 −9

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Dec 18, 2024

References:

Jira: MNTOR-
Figma:

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mansaj mansaj requested a review from rhelmer December 18, 2024 18:36
rhelmer
rhelmer approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'd consider putting it in constants.ts which is meant for this sort of thing

src/scripts/cronjobs/monthlyActivityFree.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5429-mgjlpikfea-uk.a.run.app

@mansaj mansaj merged commit 0b7c3dd into main Dec 18, 2024
16 checks passed
@mansaj mansaj deleted the MNTOR-3857 branch December 18, 2024 19:06
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5429' destroyed, cloud run service 'blurts-server-pr-5429' destroyed

@mansaj mansaj restored the MNTOR-3857 branch December 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmer rhelmer rhelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansaj @rhelmer