Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3656: log not throw "User is not eligible for feature" #5406

Merged
merged 2 commits into from
Dec 13, 2024
Merged

MNTOR-3656: log not throw "User is not eligible for feature" #5406

merged 2 commits into from
Dec 13, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Dec 12, 2024

References:

Jira: MNTOR-3656

Description

We just want to log the error without throwing to sentry

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mansaj mansaj requested a review from rhelmer December 12, 2024 20:25
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5406-mgjlpikfea-uk.a.run.app

rhelmer
rhelmer approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a question about severity but lgtm either way.

src/app/api/v1/user/welcome-scan/create/route.ts Outdated Show resolved Hide resolved
@mansaj mansaj merged commit 936a683 into main Dec 13, 2024
16 checks passed
@mansaj mansaj deleted the MNTOR-3656 branch December 13, 2024 15:40
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5406' destroyed, cloud run service 'blurts-server-pr-5406' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmer rhelmer rhelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansaj @rhelmer