Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new string for menu entry in the footer #4982

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Aug 26, 2024

References:

Jira: MNTOR-3545

@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Aug 26, 2024
@Vinnl Vinnl self-assigned this Aug 26, 2024
@Vinnl Vinnl requested a review from flodolo as a code owner August 26, 2024 13:13
Copy link
Collaborator

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be code using this string?

tumblr_efed1fa72ace34501a27bf9231101924_37b9f01c_640

@Vinnl
Copy link
Collaborator Author

Vinnl commented Aug 26, 2024

@flodolo I'm preparing that separately, but since we're deploying to prod pretty often, I figured I'd submit this first and give the localisers some time to translate it first.

Copy link

@Vinnl Vinnl merged commit be0ca85 into main Aug 26, 2024
15 checks passed
@Vinnl Vinnl deleted the MNTOR-3553-all-breaches-string branch August 26, 2024 13:28
Copy link

Cleanup completed - database 'blurts-server-pr-4982' destroyed, cloud run service 'blurts-server-pr-4982' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants