-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSAT banner for “Last scan date” (MNTOR-3146) #4611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview URL 🚀 : https://blurts-server-pr-4611-mgjlpikfea-uk.a.run.app |
rhelmer
requested changes
May 31, 2024
src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/Dashboard.test.tsx
Outdated
Show resolved
Hide resolved
src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/Dashboard.test.tsx
Outdated
Show resolved
Hide resolved
src/app/components/client/csat_survey/surveys/latestScanDateCsatSurvey.ts
Outdated
Show resolved
Hide resolved
rhelmer
approved these changes
May 31, 2024
jespy2
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cleanup completed - database 'blurts-server-pr-4611' destroyed, cloud run service 'blurts-server-pr-4611' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3146
Description
This PR adds the CSAT banner for users in the “Last scan date” experiment. This change comes with a refactor of how we add and handle multiple CSAT surveys.
How to test
(Re)build the Nimbus experiments file with
npm run build-nimbus
.Storybook
The CSAT survey banner can be easily tested in Storybook:
Using the controls the props can be changed. If the banner has been dismissed or interacted with the set cookies will prevent it from showing up again and the respective cookie needs to be deleted from the browser’s developer console.
Monitor (local)
Visit the dashboard with a free/plus user: http://localhost:6060/user/dashboard. Depending on the dashboard tab the respective CSAT survey should be shown.
The testing instructions for the “Automatic removal CSAT banner” introduced in #4421 are staying the same, except that we don’t need to add the feature flags anymore since it was converted to an experiment.
Checklist (Definition of Done)