Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSAT banner for “Last scan date” (MNTOR-3146) #4611

Merged
merged 17 commits into from
Jun 3, 2024
Merged

CSAT banner for “Last scan date” (MNTOR-3146) #4611

merged 17 commits into from
Jun 3, 2024

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented May 30, 2024

References:

Jira: MNTOR-3146

Description

This PR adds the CSAT banner for users in the “Last scan date” experiment. This change comes with a refactor of how we add and handle multiple CSAT surveys.

How to test

(Re)build the Nimbus experiments file with npm run build-nimbus.

Storybook
The CSAT survey banner can be easily tested in Storybook:

Using the controls the props can be changed. If the banner has been dismissed or interacted with the set cookies will prevent it from showing up again and the respective cookie needs to be deleted from the browser’s developer console.

Monitor (local)
Visit the dashboard with a free/plus user: http://localhost:6060/user/dashboard. Depending on the dashboard tab the respective CSAT survey should be shown.

The testing instructions for the “Automatic removal CSAT banner” introduced in #4421 are staying the same, except that we don’t need to add the feature flags anymore since it was converted to an experiment.

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Copy link

@flozia flozia self-assigned this May 30, 2024
@flozia flozia requested review from rhelmer and jespy2 May 31, 2024 15:36
@flozia flozia marked this pull request as ready for review May 31, 2024 15:36
@flozia flozia requested a review from codemist May 31, 2024 15:45
@flozia flozia requested a review from rhelmer May 31, 2024 18:50
Copy link
Contributor

@jespy2 jespy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flozia flozia merged commit ee88013 into main Jun 3, 2024
15 checks passed
@flozia flozia deleted the mntor-3146 branch June 3, 2024 14:52
Copy link

github-actions bot commented Jun 3, 2024

Cleanup completed - database 'blurts-server-pr-4611' destroyed, cloud run service 'blurts-server-pr-4611' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants