Mntor-3130 - Verify that the Apps&Services header options work correctly. #4608
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Preview URL 🚀 : https://blurts-server-pr-4608-mgjlpikfea-uk.a.run.app |
src/e2e/specs/dashboard.spec.ts
Outdated
| await clickOnLinkAndGoBack( | ||
| dashboardPage.servicesPocket, | ||
| /getpocket\.com|apps\.apple\.com|app\.adjust\.com/, | ||
| /.*(\/pocket-and-firefox\/?).*|.*about.*|.*pocket-stay-informed.*/, |
There was a problem hiding this comment.
Similarly here... it's getting a bit confusing since I'm trying to figure out which paths belong to which hosts between these two regexps. 🤔
There was a problem hiding this comment.
Do you think there is a better way to do this if there are so many hosts and so many paths that are thus possible?
src/e2e/specs/dashboard.spec.ts
Outdated
| ); | ||
| await openProfileMenuItem( | ||
| dashboardPage.profileSettings, | ||
| /.*\/user\/settings.*/, |
There was a problem hiding this comment.
Same here re: https://monitor.mozilla.org/user/settings
I wonder if we could get the current project's baseURL and use await expect(page).toHaveURL(domainAndPath);
There was a problem hiding this comment.
I'd still need to call .waitForURL() and pass in that URL. At that point, isn't it redundant?
|
Cleanup completed - database 'blurts-server-pr-4608' destroyed, cloud run service 'blurts-server-pr-4608' destroyed |
References:
Jira: MNTOR-3130
Figma:
Description
Similarly to mntor-3131, goes to each option and verifies URL. For Apps&Services header, checks the URL based on a single RegExp.
Screenshot (if applicable)
Not applicable.
How to test
npx playwright test -g "Verify that the Apps and Services header options work correctly."
Checklist (Definition of Done)