Skip to content

Commit

Permalink
append 3880 to commented out code
Browse files Browse the repository at this point in the history
  • Loading branch information
codemist committed Dec 16, 2024
1 parent fa50655 commit d0f3de2
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/app/components/client/FixNavigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const Steps = (props: {
</div>
);
const dataBrokerStepCompleted = hasCompletedStepSection(props.data, "Scan");
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// && hasCompletedStepSection(props.data, "DataBrokerManualRemoval");

return (
Expand Down
8 changes: 4 additions & 4 deletions src/app/components/client/exposure_card/ExposureCard.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import Meta, {
DataBrokerManualRemoved,
DataBrokerRemoved,
DataBrokerRequestedRemoval,
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// DataBrokerRemovalUnderMaintenance,
// DataBrokerRemovalUnderMaintenanceFixed,
} from "./ExposureCard.stories";
Expand Down Expand Up @@ -76,7 +76,7 @@ describe("ScanResultCard", () => {
expect(innerDescription).toBeInTheDocument();
});

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// Data broker removal under maintenance
// eslint-disable-next-line jest/no-commented-out-tests
// it("shows the right description for a scan result card with removal under maintenance status", () => {
Expand All @@ -93,7 +93,7 @@ describe("ScanResultCard", () => {
// expect(innerDescription).toBeInTheDocument();
// });

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// Data broker removal under maintenance resolved
// eslint-disable-next-line jest/no-commented-out-tests
// it("shows the right description for a scan result card with removal under maintenance status that's been resolved", () => {
Expand Down Expand Up @@ -122,7 +122,7 @@ describe("ScanResultCard", () => {
expect(innerDescription).toBeInTheDocument();
});

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// Data broker removal under maintenance
// eslint-disable-next-line jest/no-commented-out-tests
// it("shows the right description for a scan result card where removal is under maintenance", () => {
Expand Down
6 changes: 3 additions & 3 deletions src/app/components/client/exposure_card/ScanResultCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export const ScanResultCard = (props: ScanResultCardProps) => {
// Data broker cards manually resolved do not change their status to "removed";
// instead, we track them using the "manually_resolved" property.

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// if (scanResult.broker_status === "removal_under_maintenance") {
// if (scanResult.manually_resolved) {
// return l10n.getFragment(
Expand Down Expand Up @@ -252,7 +252,7 @@ export const ScanResultCard = (props: ScanResultCardProps) => {
);
}

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// if (props.scanResult.broker_status === "removal_under_maintenance") {
// return <span>{props.resolutionCta}</span>;
// }
Expand Down Expand Up @@ -328,7 +328,7 @@ export const ScanResultCard = (props: ScanResultCardProps) => {
<dd>
<StatusPill
// isRemovalUnderMaintenance={
// // TODO: Waiting for criteria for data brokers under maintenace to be determined
// // TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// // scanResult.broker_status === "removal_under_maintenance"
// }
exposure={scanResult}
Expand Down
8 changes: 4 additions & 4 deletions src/app/components/server/StatusPill.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type ExposureProps = { exposure: Exposure };
export type Props = (DirectTypeProps | ExposureProps) & {
enabledFeatureFlags?: FeatureFlagName[];
note?: string;
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// isRemovalUnderMaintenance?: boolean;
};

Expand Down Expand Up @@ -77,7 +77,7 @@ type StatusLabelProps = {
exposure?: Exposure;
pillType: string;
l10n: ExtendedReactLocalization;
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// isDataBrokerUnderMaintenance?: boolean;
};

Expand All @@ -89,7 +89,7 @@ const getStatusLabel = (props: StatusLabelProps): string => {
if (manuallyRemoved) {
return props.l10n.getString("status-pill-removed");
}
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// if (props.isDataBrokerUnderMaintenance) {
// return props.l10n.getString("status-pill-action-needed");
// }
Expand All @@ -111,7 +111,7 @@ const getStatusLabel = (props: StatusLabelProps): string => {
export const getExposureStatus = (
exposure: Exposure,
additionalRemovalStatusesEnabled: boolean,
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// isRemovalUnderMaintenance: boolean,
): StatusPillType => {
if (isScanResult(exposure)) {
Expand Down
2 changes: 1 addition & 1 deletion src/app/functions/server/getRelevantGuidedSteps.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ describe("getNextGuidedStep", () => {
).toBe("Done");
});

// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// eslint-disable-next-line jest/no-commented-out-tests
// it("links to the removal under maintenance step if a user has scan resutls with a data broker that has a removal under maintenance status", () => {
// expect(
Expand Down
4 changes: 2 additions & 2 deletions src/app/functions/server/getRelevantGuidedSteps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export function isEligibleForStep(
stepId: StepLink["id"],
): boolean {
// Only premium users can see the manual data broker removal flow, once they have run a scan
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// if (stepId === "DataBrokerManualRemoval") {
// const dataBrokersRequireManualRemoval =
// data.latestScanData?.results?.some((result) => {
Expand Down Expand Up @@ -245,7 +245,7 @@ export function hasCompletedStep(
data: StepDeterminationData,
stepId: StepLink["id"],
): boolean {
// TODO: Waiting for criteria for data brokers under maintenace to be determined
// TODO: MNTOR-3880 Waiting for criteria for data brokers under maintenace to be determined
// if (stepId === "DataBrokerManualRemoval") {
// return (
// data.latestScanData?.results?.every(
Expand Down

0 comments on commit d0f3de2

Please sign in to comment.