Skip to content

Commit

Permalink
Remove TODOs per flozia
Browse files Browse the repository at this point in the history
  • Loading branch information
rhelmer committed Dec 20, 2024
1 parent fd6e2c7 commit 43b1d9c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/app/hooks/useGlean.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,13 @@ export const useGlean = () => {
// Record the `plan_tier` key on all events.
// `plan_tier` is set on every metric, but it's too much work for TypeScript
// to infer that — hence the type assertion.
//
// TODO can we fix this? It looks like these are only for button->click which is misleading.
(data as GleanMetricMap["button"]["click"]).plan_tier = isPremiumUser
? "Plus"
: "Free";

// Record the `nimbus_*` keys on all events.
// `nimbus_*` is set on every metric, but it's too much work for TypeScript
// to infer that — hence the type assertion.
//
// TODO can we fix this? It looks like these are only for button->click which is misleading.
console.debug({ event, experimentData });
if (experimentData) {
(data as GleanMetricMap["button"]["click"]).nimbus_user_id =
Expand Down

0 comments on commit 43b1d9c

Please sign in to comment.