-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open the specific version directory and manifest.json (or other specified file) when version is downloaded #47
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 90.67% 90.18% -0.49%
==========================================
Files 23 24 +1
Lines 1608 1702 +94
Branches 137 137
==========================================
+ Hits 1458 1535 +77
- Misses 149 165 +16
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
3fd7c9f
to
e8d70a6
Compare
if (context.globalState.get("filePath") !== undefined) { | ||
const filePath = context.globalState.get("filePath")?.toString(); | ||
const lineNumber = context.globalState.get("lineNumber")?.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting this state and cleaning it up should be handled in a pair of functions on a relevant object. This might be a good fit for a general "AssayApp" class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
Closes #36, closes #32 and implements #31 and #43 on the Assay side.
Changes
vscode://mozilla.assay/review/<guid>/<version>?path=<path>#L<line(s)>
, the file located at<path>
will be opened in stead of manifest.json, focused on <line(s)> (ex. #L25, #L25-30...).Video Link
Note: Since Assay is currently running in a development host window, the new windows it opens are regular instances of VS Code -- i.e, ones that do not have the Assay extension. Thus, its functionality is not carried over with external windows, and the manifest.json (or other file) will not open. This would not be an issue if Assay is a properly installed extension, as it is toggled to start on launch of a new VS Code instance. For testing purposes, you can set
forceNewWindow
tofalse
on line 21 ofopenFromurl.ts,
OR bundle and install the extension usingvsce
.Instead of creating a new workspace or stacking on top of the existing one every time a new version is opened (which prompts the user to save the workspace every time they want to exit), the directory is opened directly in the explorer via vscode.openFolder.
The commenting/review system is only launched if the user is inside the root folder. That way, Assay does not get in the way of the user’s other VS Code projects. Only the Assay commands menu launches (from where the user can still download by URL, enter their API key/secret, etc.)