Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/64] login 방식 변경 #65

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

[Feat/64] login 방식 변경 #65

wants to merge 15 commits into from

Conversation

jiyoon1156
Copy link
Member

Issue number

close: #64

Description

기존 login 방식을 oauth + webview를 사용한 login 방식으로 변경했습니다.

Checklist

  • PR 제목은 알맞게 작성되었는가
    • commit convention 형식과 동일한 포맷으로 작성할 것
  • assignee가 본인으로 되어있고, lebel은 PR 주제에 맞게 추가했는가
  • description에 PR에 대해 구체적으로 설명했는가

@jiyoon1156 jiyoon1156 added the feat A new feature label Jul 20, 2022
@jiyoon1156 jiyoon1156 requested review from swimjiy and hyun0p July 20, 2022 11:30
@jiyoon1156 jiyoon1156 self-assigned this Jul 20, 2022
@jiyoon1156 jiyoon1156 changed the title Feat/64 [Feat/64] login 방식 변경 Jul 20, 2022
Copy link
Member

@swimjiy swimjiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 sns 로그인이 생겼군요 감동...근데 expo로 테스트하는데 제 폰에선 아래 영상처럼 redirect페이지 이후로 넘어가지 않네요ㅠ 제가 테스트를 잘못한건지 아님 어디에서 문제가 생긴건지 확인 부탁드려도 될까요??

KakaoTalk_Video_2022-07-21-10-44-04.mp4

app/config/consts.ts Show resolved Hide resolved
app/screens/initial/InitScreen.tsx Outdated Show resolved Hide resolved
app/screens/initial/InitScreen.tsx Outdated Show resolved Hide resolved
app/screens/initial/InitScreen.tsx Outdated Show resolved Hide resolved
app/screens/mypage/ChangeProfileScreen.tsx Outdated Show resolved Hide resolved
app/screens/mypage/MypageScreen.tsx Outdated Show resolved Hide resolved
@jiyoon1156
Copy link
Member Author

@swimjiy github만 안됐던 문제가 배포된 서버 .env가 업데이트 안돼서 로그인이 안되는거였습니다..ㅜenv 파일 업데이트 + 서버 재배포 후 정상동작하는거 확인했는데 다시 해보시고 또 안되시면 말씀주세요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth2.0 로그인, 프로필 변경 기능
2 participants