Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 01-08-2023] : New UI Revamp, Max Storage Limit Handling, Bluetooth permission handling and Other Refactoring #765

Merged
merged 545 commits into from
Aug 2, 2023

Conversation

vijay151096
Copy link
Contributor

Sprint 4 :

  • INJI-94: Environment Agnostic Inji app
  • INJI-131: add translations for labels
  • INJI-136: Rename app to Inji
  • INJI-106: Improve Bluetooth state and permission handling
  • INJI-84: Move away from Google Nearby API
  • INJI-83 Remove Google Nearby code and state machine from INJI

Other changes

  • [Android] bump up targetSDKverion to 31 as part of INJI-106

Sprint 5 :

Fixes :

INJI-151 - Display disk full warning message when device space is >= 20 MB

NEW UI Enhancements :

In JIRA :
INJI-5 - As a resident I should be able to remove the card from the wallet using the option in kebab-popup.
INJI-8 - Able to expand the QR code in the details.
INJI-22 - As a resident able to choose the language among the implemented 6.
INJI-23 - Create a "Help-screen" on the home page.
INJI-55 - Set timer after sending the OTP.

Github-Board :
#312 - Qr login screens as per latest wireframes.
#462 - Splash Logo screen.
#463 - 4- intro screens (Onboarding overlays)
#464 - Choose language overlay in the settings screen.
#465 - Auth screens as per wireframes in the new UI.
#466 - Home screen changes.
#468 - Create a kebab popup on the home screen.
#469 - Scan & send Vc screens as per new UI wireframes.
#529 - Create downloading card popup on the home screen.
#681 - Kebab menu with the working options (Pin, Unpin, View Activity, Authentication, Remove card).
#682 - UI changes for VC, VC-details and Settings.

Sprint 6 :

Sprint 5 UI merge fixes:
INJI-206 MMKV Storage Issue
INJI-208 INJI App crashing intermittently
INJI-209 QR/ Esignet login in INJI app is failing
INJI-210 After closing the VC share success status overlay, the sharing screen is displayed
INJI-212 After VC sharing, app page is still stuck in 'In progress'

Enhancements:

INJI-178 - Calculate and store encrypted HASH (HMAC SHA256) of the VC's metedata (key) in database
INJI-139 - switch between the environments from Inji App itself
INJI-172 - Prevent VC sharing if audit logs are full
INJI-182 - Pass unique ID (App ID/ Trace ID) in INJI API calls
INJI-162 - Generate & display App ID in INJI
INJI-149 - Downloaded VC , Received ID & history of the app got deleted
INJI-173 - Create a pipeline for beta release to playstore

Fixes:
INJI-190 - Back action is not working after displaying VC
INJI-92 - error label for downloading VC from deactivated VC is not proper
INJI-211 - Sprint 6 merge | List of major and critical issues
INJI-225 - Android - app crashed when we clicked on "click here" button on about INJI
INJI-223 - While sharing the vc if we click on scan icon show the camera

adityankannan-tw and others added 30 commits May 26, 2023 18:18
…#725)

* Test update readme for read access

Signed-off-by: adityankannan-tw <[email protected]>

* iOS workflow added

* iOS slack webhook added

* Add a workflow file to build app for every push

* Add empty debug keystore file to populate it

* Add empty debug keystore file to populate it

* fastlane match file added

* modify api_key duration

* Remove keystore exemption from git ignore

* Check for debug keystore file in app directory

* Give permission for keystore file to access it

* Give permission for keystore file to access it

* Print the env variables for keystore

* Use same password for both store and key and build the app

* Use same password for both and generate in app and build the app

* Print debug keystore path and debug it

* Print debug keystore path and debug it in fastfile

* Export from the current folder and remove sudo

* Generate release keystore and build the app

* Generate release keystore and build the app try 2

* Generate release keystore and build the app try 3

* Add encoded api key

* fastlane match password added

* fastlane match key added

* Match file env modified

* set keystore env for specific tasks and build the app

* set keystore env for specific tasks and build the app try 2

* set keystore env for specific tasks and build the app try 3

* set keystore env for specific tasks and build the app try 4

* set keystore env for specific tasks and build the app try 5

* bumping version

* create a env file to store env variables and build the app

* create a env file in fastlane and load it to build the app

* create a env file in fastlane and load it to build the app try 2

* app id added

* signing identities added

* Pass env from workflow to fastfile and build

* Build app in workflow file only

* Update the version code in build.gradle and build the app

* Update the version code in build.gradle and confirm changes by logging

* Update the version code in build.gradle and confirm changes by logging 2

* Double check the version code changes and build the app

* Add logs to see version code is changes or not

* Add logs to see version code is changes or not try 2

* Add logs to see version code is changes or not try 3

* Add logs to see version code is changes and give execute permission

* Build app without exporting the keystore

* Build app without exporting the keystore and bump version

* Build app by exporting the keystore in a task

* Build the app without fastlane

* unlock keychain key added

* fastfile changes

* config modified

* xcode proj config added

* xcode proj config added

* fastfile config added

* fastfile config added

* modified cert

* Fastfile config added

* updated key to test workflow

* Fastfile config updated

* changed to manual match of provisioning profile

* Check for git tag

* Check for git tag and echo it

* Check for git tag using try catch

* Check for git tag and print it

* Add a tag and try to print it

* Add a tag and try to run the task

* Add a tag and try to run the task try 2

* Change keystore path and build the app

* Change keystore path in build.gradle and build the app

* fastfile configured

* match modified

* match modified

* Clean up the code base

* Clean up the code base

* Clean up the code base and give permission

* testers added

* Internal testers group

* Trigger on workflow push

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* Add a PR trigger for ci-publish

* Add a env for keystore job

* Added actual env for testers

* Add a env for keystore job and export job

* Adjust env variables for jobs

* Make env as global

* Refactor the code base and clear files

* [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name

---------

Signed-off-by: adityankannan-tw <[email protected]>
Co-authored-by: MOSIP <[email protected]>
Co-authored-by: Adityan Kannan <[email protected]>
Co-authored-by: Dhivya <[email protected]>
* Update android-custom-build.yml

* Test update readme for read access

Signed-off-by: adityankannan-tw <[email protected]>

* iOS workflow added

* iOS slack webhook added

* Add a workflow file to build app for every push

* Add empty debug keystore file to populate it

* Add empty debug keystore file to populate it

* fastlane match file added

* modify api_key duration

* Remove keystore exemption from git ignore

* Check for debug keystore file in app directory

* Give permission for keystore file to access it

* Give permission for keystore file to access it

* Print the env variables for keystore

* Use same password for both store and key and build the app

* Use same password for both and generate in app and build the app

* Print debug keystore path and debug it

* Print debug keystore path and debug it in fastfile

* Export from the current folder and remove sudo

* Generate release keystore and build the app

* Generate release keystore and build the app try 2

* Generate release keystore and build the app try 3

* Add encoded api key

* fastlane match password added

* fastlane match key added

* Match file env modified

* set keystore env for specific tasks and build the app

* set keystore env for specific tasks and build the app try 2

* set keystore env for specific tasks and build the app try 3

* set keystore env for specific tasks and build the app try 4

* set keystore env for specific tasks and build the app try 5

* bumping version

* create a env file to store env variables and build the app

* create a env file in fastlane and load it to build the app

* create a env file in fastlane and load it to build the app try 2

* app id added

* signing identities added

* Pass env from workflow to fastfile and build

* Build app in workflow file only

* Update the version code in build.gradle and build the app

* Update the version code in build.gradle and confirm changes by logging

* Update the version code in build.gradle and confirm changes by logging 2

* Double check the version code changes and build the app

* Add logs to see version code is changes or not

* Add logs to see version code is changes or not try 2

* Add logs to see version code is changes or not try 3

* Add logs to see version code is changes and give execute permission

* Build app without exporting the keystore

* Build app without exporting the keystore and bump version

* Build app by exporting the keystore in a task

* Build the app without fastlane

* unlock keychain key added

* fastfile changes

* config modified

* xcode proj config added

* xcode proj config added

* fastfile config added

* fastfile config added

* modified cert

* Fastfile config added

* updated key to test workflow

* Fastfile config updated

* changed to manual match of provisioning profile

* Check for git tag

* Check for git tag and echo it

* Check for git tag using try catch

* Check for git tag and print it

* Add a tag and try to print it

* Add a tag and try to run the task

* Add a tag and try to run the task try 2

* Change keystore path and build the app

* Change keystore path in build.gradle and build the app

* fastfile configured

* match modified

* match modified

* Clean up the code base

* Clean up the code base

* Clean up the code base and give permission

* testers added

* Internal testers group

* Trigger on workflow push

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* fastfile changes for testers

* Add a PR trigger for ci-publish

* Add a env for keystore job

* Added actual env for testers

* Add a env for keystore job and export job

* Adjust env variables for jobs

* Make env as global

* Refactor the code base and clear files

* [Dhivya|Adityan] feat(#INJI-29|31)[Android][iOS] PR trigger and automate build using fastlane and push iOS build to test flight

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the backend url and add comments and rename apk output

* [Dhivya|Adityan] refactor(#INJI-29|31)[Android][iOS] Change the workflow name

* configure macos runner

* modify command for fastlane

---------

Signed-off-by: adityankannan-tw <[email protected]>
Co-authored-by: Keshav Mishra <[email protected]>
Co-authored-by: Monobikash Das <[email protected]>
Co-authored-by: adityankannan-tw <[email protected]>
Co-authored-by: MOSIP <[email protected]>
Co-authored-by: Adityan Kannan <[email protected]>
Co-authored-by: adityankannan-tw <[email protected]>
[Release 30-05-2023] UI improvements, device specific issue fixes, permissions enhancements & Storage Optimisation
INJI-29 iOS build fixes to build from the command line.
Add iOS test flight testing groups in the github workflow
feat(INJI-94): [Vijay] Environment Agnostics Basic Implementation
vharsh and others added 23 commits July 18, 2023 11:37
Reason: when keychain.getGenericPassword errors due to a false/falsy response,
  the state machine goes ahead and clears the MMKV store and the VC
  directory as without the key the encrypted data is not meaningful,
  it may so happen that the keychain/keystore is not unlocked yet as
  most modern mobile OSes can choose to lock access to it when the phone
  is locked

Fix: earlier the state machine would go and clear the datastores without
  user intervention, this fix will give the user a prompt if encrypted
  VCs exist on app-data and allow user to try reading the keychain once
  again before silently deleting everything

Co-authored-by: KiruthikaJeyashankar <[email protected]>
Co-authored-by: Alka <[email protected]>
details about the component:

- has two buttons tryAgain & cancel each occupying half the space in the
  row
- kludge: uses similar styling for both themes
    - TODO: override the width styles in-place instead
- this component should not be used for production as this is strictly
  temporary for narrowing down in on bugs

Other changes:

- removed additional button from original MessageOverlay component
other changes:
- add Podfile.lock
- remove debug logs
feat(INJI-149): show popup on keychain read-error
…etooth permission handling and Other Refactoring
[Release 03-07-2023] : New UI Revamp, Max Storage Limit Handling, Bluetooth permission handling and Other Refactoring
@vijay151096 vijay151096 marked this pull request as ready for review August 2, 2023 07:11
@vijay151096 vijay151096 requested review from dhivya0413 and tilak-puli and removed request for dhivya0413 August 2, 2023 09:15
@dhivya0413 dhivya0413 merged commit e7bec4a into mosip:release-0.9.x Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.