no log: Replace raw html bold tag inside text with Mantine Text #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderson-oki
changed the title
anderson-oki
force-pushed
the
feature/separate-concerns-tags
branch
from
576e1e1 to
c53c975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the nested raw
<b>tag inside of theMessagecomponent in favor to protect the Separation of Concerns.A couple reasons to apply the change:
When using the raw HTML tag we need to style it by ourselves, if the Design System changes, it won't cascade the change to the components automatically.
Mantine Text component can be changed to simply style of give more accessibility by changing
<b>to<strong>at any point, since<b>is simply visual.We can add more styling as needed such as color, italic, by simply passing the properties to the component that exists instead of manually nesting and styling ourselves.