-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support binding IPv4 AND IPv6 instead of just either one or the other #2593
Conversation
This enables auto-selection of IPv4 and/or IPv6 depending on what is available on the host.
0.0.0.0 has become the fallback instead of the default.
Thanks for your contribution and sorry for the delay. |
@Omar007 can you take a look at my review and comments? |
@morpheus65535 which ones where? I don't see any 🤔 |
Sorry I forgot to submit them 🤦♂️ |
Thanks! |
There is a typo in logger.py at line 65: The name Was this part of the code tested? Also, what happens if we get a CRITICAL log message? |
It was locally but looks like this somehow slipped between the commits/push. I have it correct locally so I think I just didn't commit it properly, that's my bad 🙇
This I have no idea for. The initial mistake is def. on me but I do feel like it should've been caught by something; as far as I can tell there is a workflow present that runs the application 🤔
I'd say that is not desired. I've pushed a new MR to deal with the logging fallout of this one; #2663. Please take a look at that. |
At the moment the configuration is limiting input to either an IPv4 address or an IPv6 address even though the underlying waitress server has no problem binding both at the same time.
This updates the configuration to pass the wildcard value on to the waitress server so Bazarr can serve in both single and dual stack environments ootb.