Merge pull request #24 from moreonion/deleted-taxonomy-terms

fix: Don’t send null values for deleted taxonomy terms
moreonion · Oct 30, 2023 · f2eb927 · f2eb927
2 parents 8470080 + 65e3a48
commit f2eb927
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/integrations/campaignion_source_tags.inc b/integrations/campaignion_source_tags.inc
@@ -20,7 +20,11 @@ function campaignion_source_tags_campaignion_logcrm_event_data_alter(array &$dat
       $wrapped_node = entity_metadata_wrapper('node', $node);
       $uuid_to_property = array_flip($tags_map);
       foreach ($wrapped_node->supporter_tags->value() as $term) {
-        // Add each tag with a matching parent to its tags-array.
+        // References to deleted terms yield NULL values here: Remove them.
+        if (!$term) {
+          continue;
+        }
+        // Add each tag with a matching parent to- its tags-array.
         foreach (taxonomy_get_parents($term->tid) as $pterm) {
           if ($property = $uuid_to_property[$pterm->uuid] ?? NULL) {
             $data['action']["{$property}_tags"][] = $term->name;

diff --git a/integrations/campaignion_supporter_tags.inc b/integrations/campaignion_supporter_tags.inc
@@ -16,7 +16,10 @@ function campaignion_supporter_tags_campaignion_logcrm_event_data_alter(array &$
     if (!empty($node->supporter_tags)) {
       $wrapped_node = entity_metadata_wrapper('node', $node);
       foreach ($wrapped_node->supporter_tags->value() as $term) {
-        $data['action']['tags'][] = $term->name;
+        // References to deleted terms yield NULL values here: Remove them.
+        if ($term) {
+          $data['action']['tags'][] = $term->name;
+        }
       }
     }
   }