campaignion_action: Reduce logging of missing email addresses #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x-2.x #306 +/- ##
=============================================
- Coverage 45.62% 45.61% -0.01%
Complexity 1930 1930
=============================================
Files 301 301
Lines 10511 10513 +2
Branches 154 154
=============================================
Hits 4796 4796
- Misses 5712 5714 +2
Partials 3 3
Continue to review full report at Codecov.
|
When a form doesn’t have an email field, we should not generate a log message for each submission, that complains about that.
torotil
force-pushed
the
reduce-no-email-log
branch
from
4b7dfc3 to
cf2b853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a form doesn’t have a required email field, we should not generate a log message for each submission when there is no value. This might hide log-messages for when there is an actual problem.