[동아리원 관리 미션] 신유승 과제 제출합니다. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 개인별 출력 API -> 모든 동아리원 개인별 출력
- 기본 entity 세팅 - Map을 통한 메모리 Repository 구현 - 나이 범위 검증 기능 구현
- domain -> entity
- Map -> List로 변경
- 실력 나이로 초기화
- BACKEND -> 백엔드
- 실력: 나이로 초기화 - API 호출 시 날짜와 기수를 기준으로 실력 계산 - 파트Enum 실력 향상 월 추가
- 동아리원 등록 기능 - 개인 실력 계산 기능 - 동아리원 출력 기능
- getEachPart -> getAllMember
- api parameter `type`으로 구분
- 평균 능력 계산 기능 구현 - 정렬 기능 추가 - 파트 없으면 반환 하지 않음
- 멤버 정렬 -> DTO 정렬
morenow98
reviewed
Jan 12, 2024
Comment on lines
+11
to
+15
| PRODUCT_MANAGER("기획", List.of(Month.JANUARY, Month.MAY, Month.SEPTEMBER)), | ||
| DESIGN("디자이너", List.of(Month.FEBRUARY, Month.JUNE, Month.OCTOBER)), | ||
| FRONTEND("프론트엔드", List.of(Month.MARCH, Month.JULY, Month.NOVEMBER)), | ||
| BACKEND("백엔드", List.of(Month.APRIL, Month.AUGUST, Month.DECEMBER)); | ||
|
|
Comment on lines
+18
to
+23
| if (this.ability > o.ability) { | ||
| return -1; | ||
| } | ||
| if (this.ability < o.ability) { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
if (this.ability != o.ability) return this.ability - o.ability;
이렇게 써보는 건 어떨까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.