Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deque): fix incorrect @deque.push*() behavior when empty #1362

Closed
wants to merge 2 commits into from
Closed

fix(deque): fix incorrect @deque.push*() behavior when empty #1362

wants to merge 2 commits into from
+24 −4

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Dec 25, 2024 •
edited
Loading

Closes #1361 by addressing the immediate concern WRT the usage in cmark.

Whether tail should be a computed state instead of a save state is still an open question.

@coveralls
Copy link
Collaborator

coveralls commented Dec 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 4314

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 81.254%
Totals Coverage Status
Change from base Build 4313: 0.006%
Covered Lines: 4625
Relevant Lines: 5692
💛 - Coveralls

@rami3l rami3l requested review from peter-jerry-ye and Lampese and removed request for peter-jerry-ye December 25, 2024 02:53
@rami3l rami3l marked this pull request as draft December 25, 2024 06:08
@rami3l
Copy link
Contributor Author

rami3l commented Dec 25, 2024

Converting to draft since @peter-jerry-ye would like to have another look at the invariants in this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lampese Lampese Lampese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@deque.T's implementation is not correct
4 participants
@rami3l @coveralls @Lampese @peter-jerry-ye