add get_or_init for hashmap #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4289Details
💛 - Coveralls |
bobzhang
reviewed
Dec 23, 2024
hackwaly
force-pushed
the
yuxiang/hashmap-get-or-init
branch
from
40162fc to
e40bf50
Compare
hackwaly
force-pushed
the
yuxiang/hashmap-get-or-init
branch
from
df8ce39 to
dbf8af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1344
This PR introduce
@hashmap.T::get_or_init. It's signature slightly different fromlinked_hashmap.T::get_or_init. Whichinitparameter is a function takes key as argument.linked_hashmap.T::get_or_initdoesn't.There's no safe way to migrate
get_or_initfrom old signature to new signature. Maybe introduce a new nameget_or_add?