impl Eq/Compare traits for ArrayView

[FlammeShadow]

• missing Eq, Compare... traits impl for ArrayView #1291

[coveralls]

Pull Request Test Coverage Report for Build 4258

Details

• 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 81.22%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
builtin/arrayview.mbt	0	9	0.0%

Totals
Change from base Build 4254:	-0.1%
Covered Lines:	4541
Relevant Lines:	5591

---

💛 - Coveralls

[gmlewis]

Thank you, @FlammeShadow !
Maybe you could add a couple doc examples like you did for the other PR?

[FlammeShadow]

Maybe you could add a couple doc examples like you did for the other PR?

Oh, I thought their functions are obvious, so I didn't add doc and examples : )

[gmlewis]

Maybe you could add a couple doc examples like you did for the other PR?

Oh, I thought their functions are obvious, so I didn't add doc and examples : )

I suppose they are, but pretty cool nevertheless. 😄

[hackwaly]

self[i] != other[i]?

[hackwaly]

avoid else of for as we are using imperative here. See return in loop.

[hackwaly]

use guard?

[hackwaly]

I see op_equal is using imperative style and compare is using functional style. I suggest that to make them use same style.

I must admit that imperative style is more readable than functional style sometimes, but here seems they are equivalent. And you are free to choose one of these two style.