Implement map* and filter for ArrayView #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Pull Request Test Coverage Report for Build 4203Details
💛 - Coveralls |
3 tasks
bobzhang
reviewed
Dec 13, 2024
builtin/arrayview.mbt
Outdated
| /// ``` | ||
| /// let v = [3, 4, 5] | ||
| /// let v2 = v[1:].mapi(fn (i, x) {x + i}) | ||
| /// assert_eq!(v2, [3, 4, 6]) |
There was a problem hiding this comment.
the CI failed because the test doc is incorrect
There was a problem hiding this comment.
Sorry about that, @bobzhang !
I forgot about moon test --doc.
It should be fixed now.
Signed-off-by: Glenn Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for discussion purposes.
It relates to #1013 and #1275.
I believe that it is MUCH more flexible for the
map*functions to return anArray(instead of anArrayView).Then, code that was performing a map on an entire array could easily insert a
[1:]and now map all but the first entry without modifying any other code.Additionally, it is much easier to turn an
Arrayinto anArrayViewthan to go the other direction.