-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more write_X method and some bytes conversions to buffer #1307
Conversation
…buffer with their conversion to Bytes.
Pull Request Test Coverage Report for Build 4190Details
💛 - Coveralls |
Thanks for your contribution! The Can you separate out the bytes conversions part from this PR? Let's merge the |
Some consideration about performance: The buffer is used to write large data consisting of multiple basic types (int, bool, double, etc.). It will call If you don't want to duplicate the code, maybe changing the implementation of |
Add methods to write UInt64, Int64, UInt, Int, Double and Float into buffer with their conversion to Bytes.