Adds method to reset data object to last snapshot #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Useful for use in combination with a form e.g. when the user cancels the form the data object can be mapped back to its last known state. |
marchant
reviewed
Mar 16, 2018
| @@ -808,6 +805,12 @@ exports.RawDataService = DataService.specialize(/** @lends RawDataService.protot | |||
| * [addRawData()]{@link RawDataService#addRawData} | |||
| * call that invoked this method. | |||
| */ | |||
| mapRawDataToObject: { | |||
There was a problem hiding this comment.
doesn't that break backward compatibility or are we now in position to do so?
There was a problem hiding this comment.
will fix - the code comments were not lined up so I put it over the right function. There was a merge conflict and I removed the wrong block.
Inadvertently removed support for backwards compability.
johnnykahalawai
added a commit
that referenced
this pull request
Jun 6, 2018
This commit can be dropped after this PR is merged: #1952
tejaede
pushed a commit
that referenced
this pull request
Dec 11, 2018
This commit can be dropped after this PR is merged: #1952
marchant
pushed a commit
that referenced
this pull request
Dec 22, 2018
This commit can be dropped after this PR is merged: #1952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marchant - per our discussion, I added the capability to reset a single data object.