Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5124: reconstruct table data using tanstack tables #1316

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Dec 3, 2024

Stories/Links:

DOP-5124

Current Behavior:

test page for tables on main branch - includes all of Atlas docs as well as the test page (sourced here)

Staging Links:

test page for tables on branch

Notes:

  • This PR does not change the way tables are rendered, or how they should be used in ReST. This updates the logic for constructing table data on the front end, so that we can pass processed column/row data, enabling us to use farther features as expanded content and/or nested tables.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit 648c2d9
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/6751c3cfd760b6000833867e
😎 Deploy Preview https://deploy-preview-1316--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 648c2d9
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/6751c3cf4bc8b400081c36a4
😎 Deploy Preview https://deploy-preview-1316--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for docs-frontend-dotcomprd ready!

Name Link
🔨 Latest commit 648c2d9
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/6751c3cf4bc8b400081c36a9
😎 Deploy Preview https://deploy-preview-1316--docs-frontend-dotcomprd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark marked this pull request as ready for review December 3, 2024 17:34
Copy link
Collaborator

@biancalaube biancalaube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in the staging link the Nested table with header rows had some weird spacing. I think both the columns in the staged link are the same size, but in the main link the service column has a smaller width. Is this expected or do we want it to look as it does originally?
new link ----
Screenshot 2024-12-03 at 4 27 56 PM
old link -----
Screenshot 2024-12-03 at 4 30 45 PM

@seungpark
Copy link
Collaborator Author

I noticed that in the staging link the Nested table with header rows had some weird spacing. I think both the columns in the staged link are the same size, but in the main link the service column has a smaller width. Is this expected or do we want it to look as it does originally? new link ---- Screenshot 2024-12-03 at 4 27 56 PM old link ----- Screenshot 2024-12-03 at 4 30 45 PM

addressed! removed the styling - this was actually put in place to fix an existing issue, but that was resolved by getting the latest commit from cloud docs (seems like it was a source ReST issue)

updated the staging links above

@seungpark seungpark requested a review from biancalaube December 3, 2024 22:53
src/components/ListTable.js Show resolved Hide resolved
src/components/ListTable.js Outdated Show resolved Hide resolved
src/components/ListTable.js Outdated Show resolved Hide resolved
@seungpark seungpark requested a review from rayangler December 4, 2024 17:07
@seungpark seungpark merged commit 15bd18d into main Dec 5, 2024
14 checks passed
@seungpark seungpark deleted the DOP-5124 branch December 5, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants