-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-5189: Create Netlify function to proxy URL fetch #1310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-dotcomstg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-dotcomprd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
i80and
reviewed
Nov 21, 2024
i80and
approved these changes
Nov 21, 2024
…403-sharedinclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5189
Current Behavior:
N/A - Function does not exist yet
Staging Links:
https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/encrypt-fields.rst
https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/compatibility-table-legend.rst
https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/lifecycle-schedule-callout.rst
Notes:
url
query param to fetch the content from said URLs. The function is currently as minimal as possible and leverages basic cache headers.sharedinclude
files in both Netlify builders and the Autobuilder. This function will ideally be removed once we no longer need to supportsharedinclude
after the monorepo is all set up (will file a new ticket for this once this ticket is complete).raw.githubusercontent.com
URLs. See the parser PR for more information.README updates