Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5189: Create Netlify function to proxy URL fetch #1310

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Nov 21, 2024

Stories/Links:

DOP-5189

Current Behavior:

N/A - Function does not exist yet

Staging Links:

https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/encrypt-fields.rst

https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/compatibility-table-legend.rst

https://deploy-preview-1310--docs-frontend-stg.netlify.app/.netlify/functions/fetch-url?url=https://raw.githubusercontent.com/10gen/docs-shared/main/dbx/lifecycle-schedule-callout.rst

Notes:

  • The function currently relies on the url query param to fetch the content from said URLs. The function is currently as minimal as possible and leverages basic cache headers.
  • This function is intended to only be a temporary solution for 403 errors from sharedinclude files in both Netlify builders and the Autobuilder. This function will ideally be removed once we no longer need to support sharedinclude after the monorepo is all set up (will file a new ticket for this once this ticket is complete).
  • This function will be used by the parser to conditionally get content from raw.githubusercontent.com URLs. See the parser PR for more information.
  • Netlify builders examples: With 403 errors vs. No 403 errors
  • Autobuilder examples: With 403 errors vs. No 403 errors

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 26f039b
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/673f84aee3d026000897eb5d
😎 Deploy Preview https://deploy-preview-1310--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit 26f039b
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/673f84ae3ca5780008a45cc1
😎 Deploy Preview https://deploy-preview-1310--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for docs-frontend-dotcomprd ready!

Name Link
🔨 Latest commit 26f039b
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/673f84ae22d4f2000847f725
😎 Deploy Preview https://deploy-preview-1310--docs-frontend-dotcomprd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rayangler rayangler merged commit 8cf4a65 into main Nov 21, 2024
14 checks passed
@rayangler rayangler deleted the DOP-5189-403-sharedinclude branch November 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants