GODRIVER-3285 Allow update to supply sort option. #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./v2/mongocompatible changes(*ReplaceOneModel).SetSort: added ./v2/mongo/optionscompatible changes(*ReplaceOptionsBuilder).SetSort: added |
qingyang-hu
force-pushed
the
godriver3285v2
branch
4 times, most recently
from
fab1a09 to
8533d0a
Compare
qingyang-hu
force-pushed
the
godriver3285v2
branch
from
8533d0a to
5a87ba9
Compare
qingyang-hu
added
priority-2-medium
qingyang-hu
changed the title
matthewdale
reviewed
Dec 6, 2024
mongo/bulk_write_models.go
Outdated
| // matched by the sort order will be replaced. This option is only valid for MongoDB versions >= 8.0. The driver will | ||
| // return an error if the sort parameter is a multi-key map. The default value is nil. | ||
| func (rom *ReplaceOneModel) SetSort(sort interface{}) *ReplaceOneModel { | ||
| rom.Sort = &sort |
There was a problem hiding this comment.
Is taking the address of sort intentional? If so, what is the purpose?
There was a problem hiding this comment.
fat-fingers... 😅
Comment on lines
1294
to
1299
| case "sort": | ||
| sort, err := createSort(val) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error creating sort: %w", err) | ||
| } | ||
| opts.SetSort(sort) |
There was a problem hiding this comment.
The additional createSort logic seems unnecessary. Can we do something similar to the "comment" case and just pass val to SetSort?
E.g.
opts.SetSort(val)
prestonvasquez
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3285
Summary
Allow v2 update to supply sort option.
Sort option for the client bulk write will be added after #1884.
Background & Motivation