Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Add addDependencyBasedRequires configuration option #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EagleErwin
Copy link
Contributor

If you specify rpm dependencies in your pom.xml like this...

<dependency>
    <groupId>my.group.id</groupId>
    <artifactId>artifact</artifactId>
    <version>1.1.0</version>
    <type>rpm</type>
</dependency>

... and set the addDependencyBasedRequires to true in the configuration of the rpm-maven-plugin, the changes in this PR will make sure that an RPM Requires is added for the specified version (or larger).

It is (in this example) equivalent to setting this in the configuration of the rpm-maven-plugin:

<requires>
    <require>my.group.id.artifact &gt; 1.1.0</require>
</requires>

This implementation requires the rpm executable to be present on the build environment for getting the required information from the dependencyArtifact file.

@EagleErwin
Copy link
Contributor Author

This PR is now open for a few months, without any response. Is there any chance that it will be either merged or closed?

@robth
Copy link

robth commented Sep 20, 2018

We're using this PR and would really appreciate it to be merged and released.

To avoid duplication of dependency information from the Maven pom file towards the <requires> list of the rpm-maven-plugin configuration a new Parameter is added: addDependencyBasedRequires.

The idea of this feature is that the rpm-maven-plugin itself inspects the dependencies of the project in which it is executed and adds a Require: [rpm-name] >= [rpm-version] for each found RPM dependency.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants