Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: add codecov #180

Merged
merged 1 commit into from
Dec 18, 2024
Merged

gha: add codecov #180

merged 1 commit into from
Dec 18, 2024

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah thaJeztah force-pushed the add_codecov branch 2 times, most recently from 857a4e0 to 89e52fa Compare December 18, 2024 17:27
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review December 18, 2024 17:43
@thaJeztah
Copy link
Member Author

OK, I think this is working;

=> Running upload-coverage
      ./codecov  upload-coverage --git-service github --sha f5305cea0432e651a4d785db82cb9541cc900d88 --branch thaJeztah:add_codecov --gcov-executable gcov
info - 2024-12-18 17:38:05,181 -- ci service found: github-actions
warning - 2024-12-18 17:38:05,190 -- xcrun is not installed or can't be found.
warning - 2024-12-18 17:38:05,192 -- No gcov data found.
warning - 2024-12-18 17:38:05,192 -- coverage.py is not installed or can't be found.
info - 2024-12-18 17:38:05,201 -- Found 7 coverage files to report
info - 2024-12-18 17:38:05,201 -- > /home/runner/work/sys/sys/reexec/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/mount/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/mountinfo/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/sequential/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/user/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/signal/coverage.txt
info - 2024-12-18 17:38:05,202 -- > /home/runner/work/sys/sys/symlink/coverage.txt
info - 2024-12-18 17:38:05,876 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/moby/sys/commit/f5305cea0432e651a4d785db82cb9541cc900d88
info - 2024-12-18 17:38:06,036 -- Process Upload complete
Screenshot 2024-12-18 at 18 41 53

Comment on lines +3 to +15
github_checks:
annotations: false

coverage:
status:
patch: false
# project will give us the diff in the total code coverage between a commit
# and its parent
project:
default:
target: auto
threshold: "15%"
changes: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were copied from what we had in moby/moby and docker/cli. Not sure if they're all needed, but at least basic functionality works. We could enable it leaving comments, but they are sometimes a bit noisy, so I left that off for now

@thaJeztah thaJeztah merged commit ca0444f into moby:main Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants