-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: add codecov #180
Merged
Merged
gha: add codecov #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
add_codecov
branch
2 times, most recently
from
December 18, 2024 17:27
857a4e0
to
89e52fa
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
add_codecov
branch
from
December 18, 2024 17:36
89e52fa
to
f5305ce
Compare
thaJeztah
commented
Dec 18, 2024
Comment on lines
+3
to
+15
github_checks: | ||
annotations: false | ||
|
||
coverage: | ||
status: | ||
patch: false | ||
# project will give us the diff in the total code coverage between a commit | ||
# and its parent | ||
project: | ||
default: | ||
target: auto | ||
threshold: "15%" | ||
changes: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were copied from what we had in moby/moby and docker/cli. Not sure if they're all needed, but at least basic functionality works. We could enable it leaving comments, but they are sometimes a bit noisy, so I left that off for now
vvoland
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.