capability: test improvements #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use testing.TB so it can also be used from a benchmark. 2. Add a call to t.Helper. Signed-off-by: Kir Kolyshkin <[email protected]>
- do not manipulate bounding set, it is not needed; - use a single list; add one more capability to it; - set Permitted/Inheritable/Effective at once; - use Unset to unset a capability; - use loop for the last check. Signed-off-by: Kir Kolyshkin <[email protected]>
lifubang
reviewed
Oct 11, 2024
| pid.Set(AMBIENT, capAmbient...) | ||
| if err = pid.Apply(CAPS | BOUNDING | AMBIENT); err != nil { | ||
|
|
||
| list := []Cap{CAP_KILL, CAP_CHOWN, CAP_SYS_CHROOT} |
There was a problem hiding this comment.
From docker to kubernetes, they always fill each type cap sets with the same cap bits, I think maybe it's wrong. So I want to test cap sets with different caps, this is my thought.
But anyway, it's not worth to be different in this test.
There was a problem hiding this comment.
Yes, I understand that (what I don't understand is why they do it that way -- for example, why drop bounding capabilities at all; but that is way out of scope for this PR).
lifubang
approved these changes
Oct 11, 2024
tianon
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
@lifubang PTAL