vendor: test moby master and pkg/system refactor #5602
Draft
+2,769
−3,728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/dependencies
thaJeztah
force-pushed
the
bump_engine
branch
3 times, most recently
from
5151702 to
f5f8615
Compare
thaJeztah
force-pushed
the
bump_engine
branch
from
3449c22 to
788846e
Compare
thaJeztah
force-pushed
the
bump_engine
branch
2 times, most recently
from
a574de9 to
c98bcdf
Compare
thaJeztah
commented
Dec 21, 2024
go.mod
Outdated
| @@ -2,6 +2,11 @@ module github.com/moby/buildkit | |||
|
|
|||
| go 1.22.0 | |||
|
|
|||
| // FIXME(thaJeztah): testing https://github.com/moby/moby/pull/49162 (pkg_system_volume_uuid branch) | |||
There was a problem hiding this comment.
Added (not yet merged) commit to remove use of pkg/system 🎉
thaJeztah
force-pushed
the
bump_engine
branch
from
d12966b to
0b19807
Compare
thaJeztah
commented
Dec 23, 2024
go.mod
Outdated
Comment on lines
5
to
6
| // FIXME(thaJeztah): testing https://github.com/moby/moby/pull/49087 (split-idtools-internal branch) | ||
| replace github.com/docker/docker => github.com/dmcgowan/docker v1.1.3-0.20241223115939-cb7934ca2190 |
There was a problem hiding this comment.
- Now testing the idtools refactor from Split idtools to an internal package and package to be moved moby#49087
There was a problem hiding this comment.
OK; looks like that's failing;
0.137 + xx-go build '-gcflags=' -ldflags '-X github.com/moby/buildkit/version.Version=v0.18.0-55-g80600495c -X github.com/moby/buildkit/version.Revision=80600495cbc8c0c439d71fc77f146cb26fabcfa5 -X github.com/moby/buildkit/version.Package=github.com/moby/buildkit -extldflags '"'"'-static'"'" -tags 'osusergo netgo static_build seccomp ' -o /usr/bin/buildkitd ./cmd/buildkitd
71.51 # github.com/moby/buildkit/cmd/buildkitd
71.51 cmd/buildkitd/util_linux.go:25:27: undefined: idtools.LoadIdentityMapping
26a483e to
97b79f2
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…93d350 full diff: vishvananda/netlink@v1.3.0...084abd9 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Removes uses of the deprecated github.com/docker/docker/pkg/reexec package in favor of the github.com/moby/sys/reexec module. full diff: moby/moby@v27.4.1...v27.5.0-rc.1 Signed-off-by: Sebastiaan van Stijn <[email protected]>
no changes in vendored code full diff: docker/cli@v27.4.1...v27.5.0-rc.1 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_engine
branch
from
97b79f2 to
1147368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/poolsin archive moby#49117