llbsolver: tie op metadata to the op before recomputing digests #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recomputing digests happens, the metadata is lost. This previously happened only with sources that were affected by source policies so it wasn't noticed, but now any LLB Op that is rewritten is affected since the gogo protobuf switch will cause all digests to be rewritten if the frontend and buildkit are using different versions. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
recompute-digests-fix-metadata
branch
from
700fcf7 to
c644fb8
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
recompute-digests-fix-metadata
branch
from
b6b8e75 to
d1a3df3
Compare
tonistiigi
approved these changes
Dec 3, 2024
|
For the testing side, I added #5562 ,but the main issue is that this appears when client/frontend is on a different version than the daemon (when the proto marshal creates different results for them). We should try if we can run the CI from pinned frontend/test versions against the latest buildkit to catch issues like this early. |
cpuguy83
approved these changes
Dec 3, 2024
This was referenced Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5558
When recomputing digests happens, the metadata is lost. This previously happened only with sources that were affected by source policies so it wasn't noticed, but now any LLB Op that is rewritten is affected since the gogo protobuf switch will cause all digests to be rewritten if the frontend and buildkit are using different versions.