tests: client: enable a batch of integration tests for wcow (pt.1) #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
force-pushed
the
tests-4485-client-wcow
branch
7 times, most recently
from
c14b23b to
95e9807
Compare
profnandaa
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Dec 5, 2024
Follow up on the moby#5554 PR series. Enabling a number of previously skipped tests for Windows platform. - [x] `testInvalidExporter` Count: 1 Signed-off-by: Anthony Nandaa <[email protected]>
|
Looks like the CI failure is unrelated / flaky? |
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Dec 6, 2024
Follow up on the moby#5554 PR series. Enabling a number of previously skipped tests for Windows platform. - [x] `testInvalidExporter` - [x] `testParallelLocalBuilds` - [x] `testCallInfo` - [x] `testFrontendVerifyPlatforms` Count: 4 Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Dec 6, 2024
Follow up on the moby#5554 PR series. Enabling a number of previously skipped tests for Windows platform. - [x] `testInvalidExporter` - [x] `testParallelLocalBuilds` - [x] `testCallInfo` - [x] `testFrontendVerifyPlatforms` - [x] `testClientCustomGRPCOpts` - [x] `testRunValidExitCodes` Count: 5 > NOTE: this is a top-to-bottom runthrough of all the tests > in `client/client_test.go` that were straight-forward. > The rest will require code changes, especially most needing > `llb.AddMount` support on Windows. These will be addressed > in separate follow-up PRs. Signed-off-by: Anthony Nandaa <[email protected]>
6 tasks
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Dec 6, 2024
Follow up on the moby#5554 PR series. Enabling a number of previously skipped tests for Windows platform. - [x] `testInvalidExporter` - [x] `testParallelLocalBuilds` - [x] `testCallInfo` - [x] `testFrontendVerifyPlatforms` - [x] `testClientCustomGRPCOpts` - [x] `testRunValidExitCodes` Count: 5 > NOTE: this is a top-to-bottom runthrough of all the tests > in `client/client_test.go` that were straight-forward. > The rest will require code changes, especially most needing > `llb.AddMount` support on Windows. These will be addressed > in separate follow-up PRs. Signed-off-by: Anthony Nandaa <[email protected]>
billywr
reviewed
Dec 6, 2024
| @@ -629,12 +644,13 @@ func testHostnameSpecifying(t *testing.T, sb integration.Sandbox) { | |||
|
|
|||
| // moby/buildkit#614 | |||
| func testStdinClosed(t *testing.T, sb integration.Sandbox) { | |||
| integration.SkipOnPlatform(t, "windows") | |||
| c, err := New(sb.Context(), sb.Address()) | |||
There was a problem hiding this comment.
notice extra space after function's curl brace, check the rest of the functions
billywr
reviewed
Dec 6, 2024
iankingori
reviewed
Dec 6, 2024
billywr
approved these changes
Dec 6, 2024
A number of tests have been skipped on Windows. Enable the following tests in `client/`, with minor modifications to run/unskip on Windows: - [x] `testStdinClosed` - [x] `testHostnameLookup` - [x] `testHostnameSpecifying` - [x] `testFileOpCopyAlwaysReplaceExistingDestPaths` - [x] `testFileOpInputSwap` - [x] `testLocalSourceDiffer` - [x] `testLocalSourceWithDiffer` - [x] `testBuildHTTPSource` - [x] `testBuildHTTPSourceEtagScope` - [x] `testNoTarOCIIndexMediaType` - [x] `testOCIIndexMediatype` - [x] `testFrontendMetadataReturn` - [x] `testFrontendUseSolveResults` - [x] `testExporterTargetExists` - [x] `testLazyImagePush` - [x] `testRegistryEmptyCacheExport` - [x] `testExportLocalNoPlatformSplit` - [x] `testExportLocalNoPlatformSplitOverwrite` - [x] `testSchema1Image` - [x] `testSourceMapFromRef` count: +20 Addressing moby#4485 Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
tests-4485-client-wcow
branch
from
95e9807 to
aab2e30
Compare
crazy-max
approved these changes
Dec 9, 2024
tonistiigi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests have been skipped on Windows.
Enable the following tests in
client/, with minor modifications to run/unskip on Windows:testStdinClosedtestHostnameLookuptestHostnameSpecifyingtestFileOpCopyAlwaysReplaceExistingDestPathstestFileOpInputSwaptestLocalSourceDiffertestLocalSourceWithDiffertestBuildHTTPSourcetestBuildHTTPSourceEtagScopetestNoTarOCIIndexMediaTypetestOCIIndexMediatypetestFrontendMetadataReturntestFrontendUseSolveResultstestExporterTargetExiststestLazyImagePushtestRegistryEmptyCacheExporttestExportLocalNoPlatformSplittestExportLocalNoPlatformSplitOverwritetestSchema1ImagetestSourceMapFromRefcount: +20
Addressing #4485