Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for deserialize and update
fixes #77
I'm not loving this, tbh... you always need to pass the custom arguments now. If you forget them, you won't get a compiler error, as callback is optional, and customArg is typed as
any
.Converting to promises completely, as @alexggordon suggested in #77 is problematic too, as Promises always return asynchronously, and the fact that serializr returns synchronously if there are no async dependencies is great.
util.promisify offers a mechanism for a custom promisified function, by defining
deserialize[util.promisify.custom] = function...
, this would be a non-breaking change which would probably be better. TypeScript also correctly types the custom promisied function.